Due to me being a cool kid and never restarting my computer and/or emacs, I didn't notice that part of the functionality introduced in #20 caused the package to not load properly on boot. I'll pass this on as a reminder to myself when making changes to upstream packages like this.
Apologies for the noise that this created. :sweat_smile:
This unreverts the revert of the failing code and includes a fix. The fix is simply to not to try to check if the keymap should contain the specific key or not. It broke because the submodules had not been defined by the time we checked for it. The simplest fix I could think of was to just always add the key. For modes outside of systemd, they u key would just simply refresh the page.
cbowdon
commented
4 years ago
Due to me being a cool kid and never restarting my computer and/or emacs, I didn't notice that part of the functionality introduced in #20 caused the package to not load properly on boot. I'll pass this on as a reminder to myself when making changes to upstream packages like this. Apologies for the noise that this created. :sweat_smile:
This unreverts the revert of the failing code and includes a fix. The fix is simply to not to try to check if the keymap should contain the specific key or not. It broke because the submodules had not been defined by the time we checked for it. The simplest fix I could think of was to just always add the key. For modes outside of
systemd, theyukey would just simply refresh the page.Closes #21