search

cbowdon / daemons.el

An Emacs UI for managing init system services
GNU General Public License v3.0
102 stars 12 forks source link

Add basic Cask setup #28

Closed camdez closed 2 years ago

camdez commented 2 years ago

Any interest in using Cask? (No hard feelings if not and you want to just close without merging.)

Cask gives an easy way to have a clean build environment and thus track down compilation warnings and errors which would occur in a clean environment but might not occur in a user's specific configuration (for example, I would have noticed the warning I fixed in #27). Since many packages are so frequently loaded (e.g. cl), it can be easy to miss that these things are not universally available.

This PR adds a new make target, compile. Current output looks like this, revealing a couple warnings we might want to fix:

$ make compile
daemons-brew.el:70:1:Error: the function ‘rest’ is not known to be defined.
daemons.el:427:1:Error: the following functions are not known to be defined: tramp-dissect-file-name, tramp-file-name-user, tramp-file-name-host
make: *** [compile] Error 1
cbowdon commented 2 years ago

Sorry, I'd rather not. I appreciate it could be beneficial but I'm not spending much time on this project so it's easier for me to stick to the tools I already know. Thank you anyway.

camdez commented 2 years ago

All good. Maintainer is a challenging and (often) thankless job, so (1) thank you, and (2) I completely understood not wanting to add new tools.

That said, if you have a good workflow for detecting these kinds of issues, I'd love to hear it (and adopt it for my own contributions).

If not, I'd recommend Cask as a good option to circle back to if it ever becomes a concern.

Cheers.

cbowdon commented 2 years ago

Thanks @camdez . I don't have a good workflow for it in Elisp, so will bear Cask in mind when it inevitably does become a concern. :slightly_smiling_face: