search

cbowdon / daemons.el

An Emacs UI for managing init system services
GNU General Public License v3.0
102 stars 12 forks source link

Fix byte compile errors #29

Closed LaurenceWarne closed 1 year ago

LaurenceWarne commented 1 year ago

Hi! This PR fixes the following byte compile errors I encountered installing (using the most recent Emacs 29 pretest):

daemons-openrc.el:48:27: Warning: the function ‘s-contains?’ is not known to be defined.
daemons-openrc.el:44:17: Warning: the function ‘s-trim’ is not known to be defined.

In daemons-systemd--item-is-simple-service-p:
daemons-systemd.el:61:2: Warning: docstring wider than 80 characters

In daemons--daemon-at-point:
daemons.el:159:2: Warning: docstring wider than 80 characters

In daemons--run-with-output-buffer:
daemons.el:178:2: Warning: docstring wider than 80 characters

In daemons--run:
daemons.el:193:2: Warning: docstring wider than 80 characters

In daemons--commands-alist:
daemons.el:237:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In daemons-define-submodule:
daemons.el:375:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In end of data:
daemons.el:132:21: Warning: the function ‘tramp-file-name-host’ is not known to be defined. daemons.el:131:21: Warning: the function ‘tramp-file-name-user’ is not known to be defined. daemons.el:130:31: Warning: the function ‘tramp-dissect-file-name’ is not known to be defined.

I've double checked intalling from my branch fixes them.

cbowdon commented 1 year ago

LGTM, thanks!