search

cboxdoerfer / ddb_musical_spectrum

Musical spectrum for the DeaDBeeF audio player
GNU General Public License v2.0
58 stars 6 forks source link

Number of bars now adjustable from plugin config window #5

Closed mwgg closed 9 years ago

mwgg commented 9 years ago

Adds an option in the Preferences->Plugins->Musical Spectrum->Configure window. Defaults to 126 to correspond to keys as intended. When changed, tooltips still display proper key.

cboxdoerfer commented 9 years ago

That's a great feature. Code seems fine, I'll do some testing when I get home and if everything works we can merge it.

As a follow-up to this patch I think it would be quite useful to add the ability to automatically determine the number of bars that best fit in the window based on a user defined bar width. Something like this:

Number of bars: [ ] manually: [0...2000] [ x ] auto: Bar width: [1...20]

Edit: oh and by the way, thx for contributing :)

mwgg commented 9 years ago

Hi, no problem. Wanted this feature from the first minute I installed the plugin, so there ya go. I'll play around with the "auto" feature some time, would be a great addition.

Is there an easy way to disable the gap between bars? For higher bar count it would be helpful. I didn't dig deep enough to figure out an on/off solution.

cboxdoerfer commented 9 years ago

Yes, disabling the gab should be possible. I'll have a look at that to make it configurable. Might look nice to have a 'solid' spectrum, instead of bars.

cboxdoerfer commented 9 years ago

gab disabled: http://i.imgur.com/l9jOYll.png

edit: and you patch seems to work nicely

mwgg commented 9 years ago

Added a checkbox to toggle gaps.

cboxdoerfer commented 9 years ago

Merged. :) I did also a few modifications (like disable vertical grid when gap is disabled)