search

cboxdoerfer / ddb_waveform_seekbar

Waveform Seekbar plugin for DeaDBeeF audio player
74 stars 10 forks source link

Enhancement: Maximize waveform setting #2

Open alioshabp opened 10 years ago

alioshabp commented 10 years ago

What I mean by maximize is that the tallest peak occupies 100% of the available width. Right now, you sometimes have small waveforms and sometimes big ones, like here: https://i.imgur.com/oywto8L.png vs here: https://i.imgur.com/47W4XSQ.png. I realize this reflects the actual loudness, and that to properly fix it I should use ReplayGain, but I prefer to leave files at their original loudness. I think by having this setting, which should be fairly easy to implement (make loudness relative to the loudest point, rather than an absolute value) the UX would be enhanced.

cboxdoerfer commented 10 years ago

Thx, sounds reasonable. I´ll see what I can do, but currently I have more important stuff on my todo (like replaygain and in-advance scanning of waveforms).

alioshabp commented 10 years ago

I agree, especially on the last task. I would help you if I could but I've never programmed in C. Still, if you want anything non-coding-related I'd love to help. This is a really awesome project.

One cool effect I noticed is that you can really see the ravages of the loudness war with this plugin - it's clear that more recent remasters have less dynamic range and are louder throughout. Except for classical music, thank god, which has largely been spared this scourge.

cboxdoerfer commented 10 years ago

Thx :) Well, I´m a C newbie myself so I don´t recommend to look at my code for studying purposes. ;) But if you like you can always help with testing the latest code, giving feedback or improving the documentation.

Yes, you can really see how crappy music got mastered over time - I´m always happy if I can at least see the individual peaks instead of a solid line. I mean this is just ridiculous: http://i.imgur.com/ryLtd1s.png

alioshabp commented 10 years ago

One small thing - I don't think it needs a separate issue. Is there a way to make the cursor width=0, i.e. not have a cursor? I find it more aesthetically pleasing without a cursor. When I change the setting in the preferences window it defaults back to 1.

cboxdoerfer commented 10 years ago

Sure, I´m already on it.

cboxdoerfer commented 10 years ago

Done.

Edit: you have to get the latest code to get it working. e.g. the deadbeef-plugin-waveform-git package from the AUR.

alioshabp commented 10 years ago

Perfect. :+1: screenshot from 2014-07-19 16 09 25