search

cboxdoerfer / fsearch

A fast file search utility for Unix-like systems based on GTK3
GNU General Public License v2.0
3.37k stars 210 forks source link

Add preview pane #121

Open Catty82 opened 6 years ago

cboxdoerfer commented 6 years ago

In theory I agree and I too would like to have something like that. However there are multiple potential issues with that feature:

  1. File previews can easily cause security issues, since you have to parse all sorts of really complex data to generate the previews

  2. Since preview handlers are quite complex -- more complex than anything else in FSearch -- they should be a separate project

  3. If the preview code isn't part of FSearch itself we need some sort of preview plugin API or a similar mechanism which allows the preview handlers to share data with FSearch

So this is really a lot of work if done right and I don't see myself doing that in the foreseeable future.

danielkrajnik commented 2 years ago

As mentioned in point 3. perhaps there could be another program that could preview the files and fsearch would just orchestrate it by sending file paths... but it's definitely more complex than that (it would be really helpful though, even at least for text files).

cboxdoerfer commented 2 years ago

@danielkrajnik There's this spec, which includes support for requesting thumbnails from the system. However I'm not sure how many systems implement that (I know XFCE does with tumbler), so that might be something worth looking into.

danielkrajnik commented 2 years ago

Thanks, that sounds like a great idea.