cboxdoerfer / fsearch

A fast file search utility for Unix-like systems based on GTK3
GNU General Public License v2.0
3.27k stars 207 forks source link

busy mouse pointer #398

Closed Golddouble closed 2 years ago

Golddouble commented 2 years ago

Describe the bug FSearch supports the possibility for double clicking on a folder and then thunar opens with the content of that folder. -> When I use this function I have a "busy mouse pointer" for about half a minute. When I remember correctly: This was not an issue with FSearch 0.1

To Reproduce Gif-Animaion: Fsearch

Expected behavior The mouse pointer is busy for about half a second or less.

Desktop (please complete the following information):

cboxdoerfer commented 2 years ago

I can't reproduce this on my system (Fedora, GNOME), but I'll try MX Linux in a VM this weekend.

I'm not a hundred percent sure about how the system implements the busy cursor, but afaik it uses the StartupNotify entry in the applications desktop file. So maybe Thunar doesn't support those notifications (so never sends a startup finished notification) but the flag is set in desktop entry in your distro.

Golddouble commented 2 years ago

Since you said that this does not occur in your system, I have now done the following: Shut down the PC and restarted it. Now the problem no longer occurs.

Sorry for the confusion.

Golddouble commented 2 years ago

OK I had this issue again.

How to reproduce:

  1. Boot the PC
  2. open FSearch
  3. type into the search field *
  4. choose picture filter
  5. double click on a folder in the folder Column to open the folder in thunar
  6. Result: All is as expected. No busy mouse pointer
  7. go back to the FSearch window
  8. repeat 4) but with another folder in the folder Column to open in thunar
  9. the mouse pointer is busy now. (Maybe you need to repeate step 4) more than one)
cboxdoerfer commented 2 years ago

Thx for the information, I'll try to reproduce it. Can you also show the output of the following command:

grep folder_open_cmd ~/.config/fsearch/fsearch.conf

Golddouble commented 2 years ago

No output with this command:

$ grep folder_open_cmd ~/.config/fsearch/fsearch.conf
Golddouble@mx:~
$ 

(?)

cboxdoerfer commented 2 years ago

No output with this command:

That's fine, this just means you didn't override the folder open command manually.

But I still can't reproduce the issue — I tried MX 21 with Xfce. I'll try MX 19 again tomorrow.

Golddouble commented 2 years ago

More Info: I have now uninstalled version Version 0.2.2 . After I have installed the old version 0.1-1 .

So I was able to test the same with the old version. And yes: I have not this issue with the old version.

After I have uninstalled version 0.1-1 and installed again version 0.2.2: Now I have again this issue.

cboxdoerfer commented 2 years ago

I've now tried to reproduce it with MX 19 (Xfce + Thunar), but no busy mouse pointer there either.

Golddouble commented 2 years ago

Thank you. Strange.

cboxdoerfer commented 2 years ago

Ah, now I can reproduce it. Do you by any chance have Thunar configured to open new instances as tabs? Because once I enable this feature, the busy mouse pointer shows up.

But this also seems to happen with other applications on my system which open the file manager. For example when I click on the "Open folder" button in the Firefox download menu, Thunar also shows the busy mouse pointer. So this seems like the issue is somewhere else. Maybe in Thunar, because it somehow doesn't notify the system that it successfully opened?

cboxdoerfer commented 2 years ago

The reason why this doesn't happen with 0.1 is because this version didn't use the startup notification system at all, when opening files or folders.

cboxdoerfer commented 2 years ago

Another application I can use to trigger this bug is mate-search-tool from the mate-utils package, by just opening one or two found folders.

cboxdoerfer commented 2 years ago

Had a quick look at Thunar's code and it's indeed a Thunar bug. Here the code returns early when Thunar opens a new tab instead of a window, without handling the startup id. Hence the system doesn't know that Thunar startup was successful and thinks it's still loading, i.e. showing the busy mouse cursor.

Golddouble commented 2 years ago

Yes, I use tabs as new instances in thunar.

... and it's indeed a Thunar bug.

I see.

The reason why this doesn't happen with 0.1 is because this version didn't use the startup notification system at all, when opening files or folders.

It's interesting.

Thank you for having a look at it. :-)

cboxdoerfer commented 2 years ago

No problem. One workaround you could use, until this bug gets fixed in Thunar, is to set StartupNotify in the thunar.desktop file to false.

You should also report it to the Thunar developers, so they become aware of the issue.