cbpowell / MarqueeLabel

A drop-in replacement for UILabel, which automatically adds a scrolling marquee effect when the label's text does not fit inside the specified frame
MIT License
4.19k stars 561 forks source link

Fixed the parameter of labelReturnedToHome method #247

Closed dolfalf closed 4 years ago

dolfalf commented 4 years ago

Check that the parameter of labelReturnedToHomecalled when scrollCompletionBlock is executed is true Changed to finished value of animation result.

This is because when labelReturnedToHome was extended by override, it was necessary to determine whether the callback occurred during the animation or that the animation ended normally.

I added a process to get a new character string when scrolling was completely completed, but when text was set (animation stopped midway), labelReturnedToHome was called, so I could not control what I wanted to do did.

cbpowell commented 4 years ago

Good catch, thanks!