cbpowell / MarqueeLabel

A drop-in replacement for UILabel, which automatically adds a scrolling marquee effect when the label's text does not fit inside the specified frame
MIT License
4.21k stars 564 forks source link

Privacy Manifests #296

Closed wlxo0401 closed 8 months ago

wlxo0401 commented 10 months ago

I don't have a bug, but I have a question.

Is MarqueeLabel not related to privacy manifest?

Read Apple docs, which say:


From Fall 2023 you’ll receive an email from Apple if you upload an app to App Store Connect that uses required reason API without describing the reason in its privacy manifest file. From Spring 2024, apps that don’t describe their use of required reason API in their privacy manifest file won’t be accepted by App Store Connect.

wlxo0401 commented 10 months ago

I checked the revised one late.

v4.4.0

wlxo0401 commented 10 months ago

스크린샷 2023-12-12 오후 3 49 08 I checked that Manifest was included, but it seems that the results of the archive are not included in the Privacy Report.

스크린샷 2023-12-12 오후 3 50 59

When I check the library file, Privacy Manifest exists in 'ZIPFoundation' and 'MarqueeLabel', but only 'ZIPFoundation' exists in Privacy Report.

cbpowell commented 10 months ago

Thanks for the heads up! I'm guessing it's not getting put into the framework/package correctly. I'll take a look into it!

wlxo0401 commented 10 months ago

@cbpowell

thank you for the reply.

I will test it when you update.

cbpowell commented 9 months ago

Just as an update, I'm waiting on some feedback from Apple on this one. I was able to replicate the ZIPFoundation report output while playing with the manifest contents, so it seems to be included correctly at least. But the question is what the correct manifest content is for a library like MarqueeLabel that collects zero data.

wlxo0401 commented 9 months ago

Just as an update, I'm waiting on some feedback from Apple on this one. I was able to replicate the ZIPFoundation report output while playing with the manifest contents, so it seems to be included correctly at least. But the question is what the correct manifest content is for a library like MarqueeLabel that collects zero data.

I tested other libraries and found a lot of the same results. Apple says it will be implemented in the spring, but it is too quiet..

But I'm glad you answered quickly. Some libraries are not even answered by the owner.

wlxo0401 commented 9 months ago

Thanks for the heads up! I'm guessing it's not getting put into the framework/package correctly. I'll take a look into it!

I discovered a new while testing.

Until now, most of the libraries that have added PrivacyInfo have not been marked in PrivacyReport.

However, when an item is added to the 'Privacy Nutrition Label Types', the library name is displayed in the PrivacyReport.

Many libraries have updated PrivacyInfo without adding anything from 'Privacy Nutrition Label Types'.

Does anyone know about this? Is 'Privacy Nutrition Label Types' a must-have item?

Or is it not necessary to display it in the privacy report?

Please feel free to leave opinion.

(I used a translator.)

cbpowell commented 8 months ago

I heard back from Apple - the correct approach is to have the appropriate keys in the Privacy Manifest, but with empty arrays (which is what MarqueeLabel has now). Thanks for the patience on this one!