cbrandlehner / homebridge-daikin-local

Supports Daikin Air Conditioners on HomeBridge
MIT License
101 stars 18 forks source link

daikinSpeedtoRaw: default case - this could be a problem #181

Closed MattGeale closed 2 years ago

MattGeale commented 3 years ago

Describe the bug Hey all, don't know if this is a bug or just a screwup on my end during initial config, but Im getting these weird errors on the Homebridge logs and while it all appears to be performing perfectly (power on/off, adjust temp, fan speed etc etc) i just want to make sure that the error might not turn the thing on or off while im away or out of the house.

To Reproduce

  1. Homebridge plugin version - Homebridge-daikin-local v2021.32.1
  2. Daikin controller unit - BRP072C42 (appled with https and token - blacked out in screenshots)

Information on your configuration: Config image image

Logs image image

Expected behavior Plugin performing perfectly, just want to get clarification if this is end user screwup or if theres a fix - can't find anything in documentation.

Thanks in advance :))

merv2k4 commented 3 years ago

I have the same issue too...

Does the fan work for you?

I can only set the AC's cooling mode and temperature. Whenever i change the fan % settings, nothing happens.

kormoc commented 2 years ago

So my unit doesn't appear to have fan control support. When I use the Daikin app, there's no fan control displayed and when I get the raw values from the /aircon/get_control_info endpoint, it does not contain the fan speeds

> curl http://192.168.28.39/aircon/get_control_info
ret=OK,pow=1,mode=4,adv=,stemp=22.0,shum=0,dt1=25.0,dt2=M,dt3=25.0,dt4=22.0,dt5=22.0,dt7=25.0,dh1=AUTO,dh2=50,dh3=0,dh4=0,dh5=0,dh7=AUTO,dhh=50,b_mode=4,b_stemp=22.0,b_shum=0,alert=255

It seems like perhaps fan support should be a config option, or detected by the lack of f_rate in the this.get_control_info response. And if the fan isn't supported, it shouldn't be exposed to homekit.

MattGeale commented 2 years ago

Im fairly sure mine has fan a Fan option as there is one on the remote as well as the app; plus the speed of the fan when the unit is set on Cool (either via remote or homekit), seems to adjust itself based on temperature. One thing that I've never been able to do is get my aircon to report the /aircon/get_control_info; everytime it says I don't have access to that page even running the command as a direct copy off of what is listed in that documentation. Homekit also reports that the "fan" is ON even when cooling; which I suppose its suppose to.

When the things not even running, it spits out those errors.

I've tried googling it and i'm fairly sure mine does have a fan mode but if anyone wants to double check, My Daikin model, it's Serial number is: FTXV85LVMA/E001738

MattGeale commented 2 years ago

@cbrandlehner any update on these mate? Cheers

MattGeale commented 2 years ago

@kormoc @merv2k4 Ok I had a brief look back into the app and the config of this thing, I think the "fan" is just a manual override of the aircon fan speed itself. If you're OK doing the following, just disable the fan in the initial config and let the aircon handle the fan speed based on the temp specified as well as the ambient temp in the room. I did that about 20 minutes ago and those errors have completely disappeared. I'll keep this thread open on the off chance anyone else has any ideas or if @cbrandlehner responds.

Also forgot to put this in but I found that when FAN was disabled, it made the responsiveness of the Homebridge communication to the Daikin Airbase significantly faster. Almost 2-3 seconds vs the original 6-7 with FAN enabled.

Also confirmed my Aircon does have a fan mode so if this is all related to there being a "fan mode not being supported" then its not an Aircon thing.

MattGeale commented 2 years ago

@cbrandlehner any update on these mate? Cheers

MattGeale commented 2 years ago

@cbrandlehner any update on these mate? Cheers

cbrandlehner commented 2 years ago

@MattGeale how did you "disable the fan in the initial config? Can you create a pull request on github with your proposed changes?

MattGeale commented 2 years ago

I didn't disable the fan in my initial config; only as a test when this error shows up (if you read above comment on the 5th of December); when I did it, I just clicked the checkbox but that put the aircon on full speed. What pull request are you talking about? I'm wanting to see what my issue is related to and if my above "daikinSpeedtoRaw: default case - this could be a problem" is anything I've done. Cheers

Edit: The original screenshots are what my Homebridge config is - hasn't changed.

MattGeale commented 2 years ago

Ok update time @cbrandlehner Since the new update thats just been pushed out, the error no longer shows up in the Homebridge logs like the above. Don't know what exactly you changed, but a welcome one nonetheless; no config changes on my end except updating the plugin. That being said, now the aircon is ignoring commands that are being sent via the fan slider and not oscilating up down/left right; is that expected behaviour? Most of the time, I just "turn the aircon on" and let the temperature probe adjust the fan speed accordingly and with oscilate turned on, i let it move up down/left right. Cheers!

Edited for Clarification

cbrandlehner commented 2 years ago

Hey @MattGeale to be honest, there is no targeted intention. I learned from users feedback that not all Daikin ACs are having the same features and so also the commands you can send to the device differ. However, my tests are limited to the single Daikin device I have installed at home. I was hoping that you are a programmer who can propose a code change to better adopt the plugin to your device. If that new code also works with other devices we can update the plugin.

MattGeale commented 2 years ago

Hey @MattGeale to be honest, there is no targeted intention. I learned from users feedback that not all Daikin ACs are having the same features and so also the commands you can send to the device differ. However, my tests are limited to the single Daikin device I have installed at home. I was hoping that you are a programmer who can propose a code change to better adopt the plugin to your device. If that new code also works with other devices we can update the plugin.

I’m an App support developer, but mostly delve into PowerApps and sql, nothing really running custom code unfortunately but I’m trying to learn more. But yeah whatever has been updated whether it was a homebridge update or the plugin update has fixed it and the “errors” aren’t showing up and the thing is working a treat currently. I’ll close up the issue just deeming it as an unknown fault and that error has been rectified. Thanks!