cbrandlehner / homebridge-daikin-local

Supports Daikin Air Conditioners on HomeBridge
MIT License
100 stars 18 forks source link

new version hang homebridge #40

Closed bubez81 closed 4 years ago

bubez81 commented 5 years ago

Hello, it's me or the new version of the plugin completely hang homebridge?

cbrandlehner commented 5 years ago

Yes, for unknown reason. Appreciate any help improving the code.

Djelibeybi commented 5 years ago

I'm not seeing a hang (Homebridge keeps running), but it stops responding to HomeKit. I've had to remove the plugin for now just to get my home operational again.

Djelibeybi commented 5 years ago

If it helps for debugging purposes, I see a lot of sendGetRequest Error: connect ETIMEDOUT 192.168.178.23:80 errors as well as getTemperatureDisplayUnits: Temperature unit is undefined. 0=Celsius, 1=Fahrenheit. warnings.

jonnor1084 commented 5 years ago

I rolled back to v2019.26.2. While it does not support swing mode, it includes fan speed/temperature controls and is free of the homebridge device hang issue.

bubez81 commented 5 years ago

it's strange i can't see any relevant error in the logs...

cbrandlehner commented 5 years ago

After long debugging I found that the URLs called did NOT cause the problem. The problem seems to be that the Daikin wifi controller can not handle a large numer of http requests in a short time. As a workaround I implemented http rate throttling. There might still be issues though!

I do not like the actual implementation of the workaround, if somebody with dev know-how can improve the code, pobably by implementing promise instead of callback, I am very happy.

ghost commented 5 years ago

What support do you need? Point me to the related code, then i will have a look - but cannot promise anything.

cbrandlehner commented 5 years ago

Thank you @NeoLeonGithub I think I was able to solve the issue. After using native http requests first I tried several modules like "request" and finally found that "superagent" seems to work best.

beatpaul commented 5 years ago

Hi! For me the plugin works fine now (thx for your great work!!) but it still reacts slower than before (2019.26.2) I have a separate instance of homebridge for it to keep the speed of the other plugins Thx for keeping it updated!

beatpaul commented 5 years ago

... after using the plugin during these hot days in Austria :) I had several problems since the plugin didn‘t react propperly I m using the plugin with 3 Accessoires @cbrandlehner will there be another update regarding this problem?

Im not a programmer, but If u need further information or feedback please just let me know

Thx for your work!

cbrandlehner commented 5 years ago

@beatpaul I did multiple tests and found that a minimum of 500ms between the HTTP requests is still stable on my controllers. The code you are currently working with is configured for 1000ms. I am going to publish a new version today with 500ms.

beatpaul commented 5 years ago

Thx for your effort! I will report here!

beatpaul commented 5 years ago

Hi!

So I tested the new Version and in general all the functions were working But still Version 2019.26.x was much faster. In more detail: When i open the iOs Home App (in the local Wifi) it takes about 15 seconds to update ("Aktualisieren") the AC & Fan Buttons until they can be used, after that everything works fine and fast. I run the Plugin on a Mac in its own instance not to slow down other plugins.

No Problem with other Plugins so far.

Tell me if u need any furhter info,

lg

cbrandlehner commented 5 years ago

This is working as designed now. There is no easy way to implement http call caching.

greensouth commented 5 years ago

it's me or since I updated the plugin, I can't use siri with the word "thermostat" as before ("Turn on thermostat, set thermostat to Xº…)

Also when changing mode (set mode to cold,heat...) from Siri, it says that the unit doesn't support such functionality.

So weird.

Maybe the service names have changed or something? it's weird, it has been working nicely since yesterday that updated to the last version.

And yep, much slower than previous versions.

cbrandlehner commented 4 years ago

@greensouth please open a new bug reports if you can reproduce this. I am closing this thread as the initial issue reported here, is fixed.