search

cbrewster / brewcode

Brew(ster) code editor
MIT License
19 stars 3 forks source link

Update deps and some other changes #1

Closed rofrol closed 4 years ago

rofrol commented 4 years ago

Sorry for this low quality PR. I am just learning all this stuff.

In the wip commit I tried to update deps to winit 0.20.0. It succeeded in next commit but now I don't see any code displayed in the editor. Just black window.

cbrewster commented 4 years ago

I just tried locally, the patch appears to work fine although the resizing needs to be fixed (see my review comment about that). What platform are you running on?

Also the delete/backspace behavior seems a bit odd, backspace should delete one character on the left of the cursor and delete should delete a char on the right side of the cursor. When I hit backspace is performs a delete instead and hitting delete does nothing. This could be another case of weird cross-platform things?

Input handling is very basic at the moment and will need to become a bit more robust in the future to better handle different keybindings across platforms.

rofrol commented 4 years ago

I am running Ubuntu 19.10 x86_64

cbrewster commented 4 years ago

Hmm okay, I can probably try this on Linux soonish, but maybe not today. Do you end up with any Vulkan validation errors when running?

rofrol commented 4 years ago

I still see black window :/

rofrol commented 4 years ago

Do you end up with any Vulkan validation errors when running?

No

cbrewster commented 4 years ago

Did it work with the old winit version?

rofrol commented 4 years ago

yes

rofrol commented 4 years ago

I have converted locally hello-triangle from wgpu-rs to winit 0.20 and it works

cbrewster commented 4 years ago

I'll look into the issue with the blank window soon. Feel free to dig into it if you'd like. This PR looks good otherwise. Font-kit support should be added separately I think.

Thanks again!

rofrol commented 4 years ago

I run it on Windows and it works 😭