Closed vahid-sb closed 2 years ago
Traceback (most recent call last):
File "C:\Users\DNI-2\miniconda3\envs\mnelab2\lib\site-packages\mnelab\mainwindow.py", line 578, in open_data
self.model.load(fname)
File "C:\Users\DNI-2\miniconda3\envs\mnelab2\lib\site-packages\mnelab\model.py", line 36, in wrapper
f(*args, **kwargs)
File "C:\Users\DNI-2\miniconda3\envs\mnelab2\lib\site-packages\mnelab\model.py", line 110, in load
data = read_raw(fname, *args, **kwargs, preload=True)
File "C:\Users\DNI-2\miniconda3\envs\mnelab2\lib\site-packages\mnelab\io\readers.py", line 79, in read_raw
_, ext = split_name_ext(fname)
TypeError: cannot unpack non-iterable NoneType object
Regarding the first issue, you have hit an edge case which occurs only on Windows using the launcher mnelab
and joblib
installed. Among other things, this is because the mnelab
launcher, which is auto-generated by pip
, redirects stdout and stderr, which leads to this error (this had more severe consequences that have been fixed, but if you are interested this is probably the most relevant issue).
There are three potential solutions:
python -m mnelab
instead of mnelab
.joblib
, then everything works even with the mnelab
launcher.pip install -U git+https://github.com/mne-tools/mne-python
); it seems like the recent changes related to computing PSDs also fixed this issue, so everything works even with the mnelab
launcher.MNE 1.2 will be released very soon, and then solution 3 will be automatically implemented. Therefore, could you please check if those three options (and especially the last one) work for you? If so, I think it's OK to wait until MNE 1.2 has been released.
I've fixed the second issue in #360.
@vahid-sb are you happy with the changes? If not, let me know what else needs to be fixed.
@cbrnr sorry for the delay in responding. I just found time to check both fixes and both issues are now resolved. Thanks for that. I will perform some more checks and tests and if I face no other issues, will update the review form accordingly.
I did more tests and looked into the code, and no did not encounter any others issues. Hence, I close this issue. Thanks for resolving the previous ones.
Hi guys As part of the review of your JOSS submissions, I have been testing MNELAB for the past few days. And decided to open this issue to mention anything that need fixing. I will add more if I notice more issues. But before that, I should congratulate you all on this repository. Obviously, there is still many features that can be added, but as it is, it is already a very impressive and useful library. I tested MNELAB under both Linux (Ubuntu 21) and Windows 10. In both cases, I created a conda environment using
conda create -n mnelab python=3.9
and after activating the environment, installed mnelab using:pip install mnelab[full]
In both cases, I used output data from Branvision Acticap-64 and also from Wearable Sensing DSI-7 recorders.While in Linux I could plot PSD with no error.