search

cbrnr / sigviewer

SigViewer is a viewing application for biosignals.
GNU General Public License v3.0
141 stars 38 forks source link

Scaling window isn't working properly I think... #88

Closed Yida-Lin closed 7 years ago

cbrnr commented 7 years ago

Do you mean the "Scale All Channels" dialog? What's the problem with it? I just tested it and there's only one minor issue that should be fixed, namely we don't check if the upper value is greater than the lower value.

Yida-Lin commented 7 years ago

@cbrnr Hmmmm. I just opened one of my file and chose fixed scaling, setting upper and lower boundary to some arbitrary values. Then all the signals are gone... weird :/ Also, after choosing fixed scaling and click OK, when reopening the dialog, it switches back to auto scaling :/

cbrnr commented 7 years ago

If the signal is not within the range defined by upper and lower values you won't see it. Can you confirm that the fixed scaling works with sensible values?

You're right, the dialog should stick to fixed scaling, this is a bug.

Given that multimodal signals can have vastly different ranges, the fixed scaling of all channels doesn't make that much sense. It was intended for EEG-only signals, which are all similarly scaled. Maybe we should think about extending this setting to individual channels as well.

Lastly, we should probably call it "manual scaling" and not "fixed scaling".