Closed cbrnr closed 1 year ago
In my opinion, the remaining errors/warnings (when setting "python.analysis.typeCheckingMode": "basic"
) are useless. These include:
values that can be None
, even if we explicitly take care of that literally in the previous line
if classifiers_dir is None:
classifiers_dir = get_config("classifiers_dir")
target_file = Path(classifiers_dir).expanduser() / name
ax[row]
, where Pylance says that we cannot index a Matplotlib Axes,@hofaflo let me know if you think we should address any of the remaining errors (and if so, please show me how).
Ima turn off type checking now to stay sane.
Pyright will still complain, but I think making mypy happy is enough :)
The mkdocstrings issue is already fixed upstream (mkdocstrings/python#45), so I bumped the dependency. 5e81986 should have worked around this, but for some reason readthedocs ignored the changed path to the configuration file and kept calling mkdocs with --config-file mkdocs.yml
instead of --config-file ./mkdocs.yml
(see the build log) :shrug:
This is ready to merge from my point of view @cbrnr :)
@hofaflo, besides my minor comments this looks really good (I've edited my comments so that all questions are in the first comment).
Regarding the
py.typed
file – why is this empty file necessary (what does it do)?
PEP561 says so :shrug:. I'm not totally sure but I assume it tells type checkers (such as mypy) that the package is typed.
And if it is necessary, should it not be included as
package_data
?
Totally, it is included in the wheels and in the source archive (I guess because its parent directory is listed in MANIFEST.in?).
I think we should add
.mypy_cache
to.gitignore
.
For some reason my VS Code already ignored it so I didn't notice, but sure, I'll add it :D
Looks great! Ready to merge?
Yes!
Thanks @hofaflo!
Fixes #93.