Closed cbrnr closed 1 year ago
I was wondering why the following classes are not exported (i.e. part of sleepecg/io/__init__.py and therefore also in the API docs):
sleepecg/io/__init__.py
sleepecg.io.sleep_readers.Gender
sleepecg.io.sleep_readers.SubjectData
These are "public" classes, and should therefore be exported (or made "private" by appending an underscore).
Similarly, sleepecg.io.gudb.GUDB_MD5 is "public" (but not exported), I think here it would be consistent to rename to _GUDB_MD5.
sleepecg.io.gudb.GUDB_MD5
_GUDB_MD5
@hofaflo WDYT?
I agree on all points!
hofaflo
commented
1 year ago hofaflo
commented
1 year ago
I was wondering why the following classes are not exported (i.e. part of
sleepecg/io/__init__.pyand therefore also in the API docs):sleepecg.io.sleep_readers.Gendersleepecg.io.sleep_readers.SubjectDataThese are "public" classes, and should therefore be exported (or made "private" by appending an underscore).
Similarly,
sleepecg.io.gudb.GUDB_MD5is "public" (but not exported), I think here it would be consistent to rename to_GUDB_MD5.@hofaflo WDYT?