remove dependency on pandas for read_gudb

cbrnr / sleepecg

Sleep stage detection using ECG

BSD 3-Clause "New" or "Revised" License

90 stars 23 forks source link

remove dependency on pandas for read_gudb #134

Closed hofaflo closed 1 year ago

hofaflo commented 1 year ago

If I remember correctly, read_gudb uses pandas because its load_csv used to be a lot faster than numpy's loadtxt. This changed in numpy 1.23.0 when the function was implemented in C, so I guess we can drop pandas as an optional requirement. I don't think it's necessary to bump the required numpy version to 1.23.0 since it is just a speed improvement, not a functional one, what do you think @cbrnr?

cbrnr commented 1 year ago

I agree, no need to bump NumPy! Can you add a changelog entry?

cbrnr commented 1 year ago

Thanks @hofaflo!