search

cbrnr / sleepecg

Sleep stage detection using ECG
BSD 3-Clause "New" or "Revised" License
86 stars 22 forks source link

Upload to PyPI fails #180

Closed cbrnr closed 1 year ago

cbrnr commented 1 year ago

@hofaflo I get an error when trying to upload to PyPI:

https://github.com/cbrnr/sleepecg/actions/runs/5141613433/jobs/9254570613

What is this UNKNOWN distribution? I remember we discussed something about how to best exclude the classifiers directory (and another one), which is maybe related? Unfortunately, I can't find that discussion anymore.

We need to fix this ASAP, because it is required to proceed with the JOSS publication. Also, I will need to delete and overwrite the v0.5.5 release once we've figured out the problem.

cbrnr commented 1 year ago

It's the source distribution build step (https://github.com/cbrnr/sleepecg/actions/runs/5141613433/jobs/9254303972).

cbrnr commented 1 year ago

Weird, running python setup.py sdist works locally. So does python -m build --sdist, which we should probably use instead in the future.

cbrnr commented 1 year ago

I'll try python -m build --sdist now (I've already rolled back everything aka rewritten history).

cbrnr commented 1 year ago

It seems to work now. No idea what the issue was, could have been a fluke (most likely). Or it was really the old python setup.py sdist, who knows.