Improvements in preprocess_rri

cbrnr / sleepecg

Sleep stage detection using ECG

BSD 3-Clause "New" or "Revised" License

90 stars 23 forks source link

Closed raphaelvallat closed 2 years ago

raphaelvallat commented 2 years ago

[x] Previously, preprocess_rri was applied in-place, which can be confusing and error-prone. We now return a copy of the array, leaving the original array unchanged.
[x] Previously, the function would fail if a list was used as the input. We now force the conversion to a numpy.array of dtype float.
[x] Added an example in docstring

Thanks, Raphael

cbrnr commented 2 years ago

Please also make sure to add a changelog entry, because returning a copy is a big change in behavior!

raphaelvallat commented 2 years ago

Done!

cbrnr commented 2 years ago

Thanks @raphaelvallat!