Bug fixes - Githubissues

cbroeckl / RAMClustR

Assigning precursor-product ion relationships in indiscriminant MS/MS data

MIT License

12 stars 16 forks source link

Bug fixes #44

Closed zargham-ahmad closed 1 year ago

zargham-ahmad commented 1 year ago

This PR contains the following:

added missing argument in reader functions and for batch.qc in ramclustR.R
slightly optimized batch.qc and fixed quantile
updated qc variable in normalized qc
added missing test for normalization functions

I have encountered two cases where QC normalization fails when qc is a vector of all FALSE or contains only 1 TRUE, so I have also added a condition for it.

hechth commented 1 year ago

@zargham-ahmad we also have to enable the CI for this branch. Also the bugfixes should be mentioned in at least one line in the changelog. Otherwise looks good to me :).