Add font-awesome functionality back

cbroeren / ember-context-menu

An ember addon for custom context-menu

https://cbroeren.github.com/ember-context-menu

MIT License

23 stars 15 forks source link

Add font-awesome functionality back #27

Closed orf closed 7 years ago

orf commented 7 years ago

Hey, ember-font-awesome has been updated recently and no longer has any bower dependencies, font-awesome is installed via npm.

Was the bower dependency the reason font-awesome functionality was removed? If so could it be re-enabled?

cbroeren commented 7 years ago

The bower dependency wasn't the reason it was enabled. It wasn't working with some newer dependencies we've updated lately.

I've seen it is updated recently, so I wanted to implement it again when I have the time for this. Currently I'm really busy, wanna try to re-implement it this week.

cbroeren commented 7 years ago

Or anyone who wants to fix this, can create a PR by bringing everything back as it was: See this commit where I removed it

cbroeren commented 7 years ago

See #28

cbroeren commented 7 years ago

Published 0.3.2