cbroeren / ember-context-menu

An ember addon for custom context-menu
https://cbroeren.github.com/ember-context-menu
MIT License
23 stars 15 forks source link

outdated FontAwesome implementation #52

Open Sogmog opened 4 years ago

Sogmog commented 4 years ago

currently the dependency "ember-font-awesome" (v4) breaks the ("@fortawesome/ember-fontawesome" v5) implementation and makes Version 5 Fonts unusable.

I cant find any way to disable the "ember-font-awesome" package to use my project fontawesome implementation: even not through the assets exclude options: https://github.com/martndemus/ember-font-awesome#excluding-assets

package.json contain the following dependencies: "@fortawesome/ember-fontawesome": "^0.2.1", "@fortawesome/free-brands-svg-icons": "^5.9.0", "@fortawesome/free-regular-svg-icons": "^5.9.0", "@fortawesome/free-solid-svg-icons": "^5.9.0",

The Logic that create an Icon for the node can also be done manually in the template and will not break any project dependencies.

Is it possible to remove the outdated "ember-font-awesome" implementation or update to a up-to-date package like: https://github.com/FortAwesome/ember-fontawesome ?