Make _ position consistent in Rotation Enum

cbrunet / python-poppler

Python binding to Poppler-cpp pdf library

GNU General Public License v2.0

95 stars 15 forks source link

Make _ position consistent in Rotation Enum #44

Closed mara004 closed 3 years ago

mara004 commented 3 years ago

This MR fixes issue #42.

The Rotation Enum did not match the upstream poppler-cpp. The position of the underscore for two attributes was unexpected and probably inadvertent. This change is somewhat API-breaking and needs additional clarification in the docs.

cbrunet commented 3 years ago

Thank you!

mara004 commented 3 years ago

No problem! Thank you for maintaining and documenting this nice library!