search

cbrunet / python-poppler

Python binding to Poppler-cpp pdf library
GNU General Public License v2.0
97 stars 15 forks source link

adding some type hints and few type checks #55

Open farooqkz opened 2 years ago

farooqkz commented 2 years ago

Hello there. I have added some Python type hints and a few type checks. Please let me know if I should change anything. Regards, Farooq.

farooqkz commented 2 years ago

So you are asking me to add type hints to all files?

cbrunet commented 2 years ago

So you are asking me to add type hints to all files?

yes, if it is something you'd like to do, it would be a great contribution. I would not add any explicit type checks however.

farooqkz commented 2 years ago

So you are asking me to add type hints to all files?

yes, if it is something you'd like to do, it would be a great contribution. I would not add any explicit type checks however.

Currently, I don't have time to do the type hints for all of the API. And I suppose having type hints for some parts is better than not having them at all.

farooqkz commented 1 year ago

@cbrunet any other change required?

EDIT: Sorry I forgot it for a long time...

farooqkz commented 1 year ago

@cbrunet enough sleep! wake up!