search

cbucher / console

This is a modified version of Console 2 for a better experience under Windows Vista/7/8/10 and a better visual rendering.
https://github.com/cbucher/console/wiki
GNU General Public License v2.0
2.93k stars 231 forks source link

ConsoleZ.sln uses v142 toolset but is in VS2017 format? #540

Open chrisant996 opened 3 years ago

chrisant996 commented 3 years ago

What configuration should I be using to compile Console?

I'm trying to compile Console because I want to track down and offer a fix for what may be a bug in ANSI escape code handling in a particular case. (I see in the wiki that Console doesn't process ANSI escape codes. The issue occurs only in Console, not in conhost or ConEmu or Windows Terminal. I want to examine Console in the debugger to be able to identify how/whether it's somehow involved. Regardless, I want to be able to build it to test changes since the April 2019 release, and to be able to potentially contribute in the future.)

When I start ConsoleZ.sln, it gets auto-detected as a VS2017 solution and loads in VS2017. But when trying to build in VS2017 it reports errors because the vcxproj files target the v142 toolset, which is part of VS2019. Looking at source logs for the vcxproj files, they were explicitly changed to reference "v142" toolset and the commit description mentions Visual Studio 2019. VS2019 refuses to open the ConsoleZ.sln file without converting it to VS2019, so it seems that I'm having trouble replicating the intended build environment.

Background:

chrisant996 commented 3 years ago

Oh, and the latest experimental build does not reproduce the ANSI escape code problem, so that appears to have been addressed.

However, I would still like to be able to build Console using the same development environment as the repo expects. (I can of course make local changes, but then I won't be able to verify whether pull requests from me will build correctly for others.)