search

cburnette / boxr

A Ruby client library for the Box Content API.
MIT License
115 stars 101 forks source link

Fix fetching too many folder collaborations #125

Open trysmr opened 1 year ago

trysmr commented 1 year ago

Hi,

The List folder collaborations API does not seem to support offset and limit. https://developer.box.com/reference/get-folders-id-collaborations/

If we specify an offset and limit smaller than total_count for the folder_collaborations, the loop in the get_all_with_pagination will increase the number of collaborators.

We should use the the get method in the folder_collaborations.

Thank you!

xhocquet commented 1 year ago

Hey @trysmr , thanks for the contribution! Your change makes sense based on the info provided. I'll take a look and see if we can get this merged in