cburstedde / libsc

The "sc" auxiliary library
www.p4est.org/
GNU Lesser General Public License v2.1
36 stars 34 forks source link

update generated pkgconfig (cmake and autotools) #127

Closed pkestene closed 1 year ago

pkestene commented 1 year ago

Update generated pkgconfig (cmake and autotools)

This is a minor change, we just expose 3 variables in pkg-config (autotools and cmake):

these are boolean variables (yes/no) to help a downstream project to quickly get information about how libsc was built.

Another change in the cmake build: we set default value for CMAKE_BUILD_TYPE to RelWithDebInfo for compatibility with autotools defaults.

cburstedde commented 1 year ago

Thanks; really cool. Should we expand this logic to include SC_ENABLE_MPIIO?

pkestene commented 1 year ago

I need to add json because it is needed in p4est for linking.

Regarding MPIIO, it looks like SC_ENABLE_MPIand SC_ENABLE_MPIIO are always identical, so I don't know if it really needed, but if you feel it is, we can.

cburstedde commented 1 year ago

I need to add json because it is needed in p4est for linking.

Ok! Same with zlib presence (do we need to know whether it is built, separately from presence)?

Regarding MPIIO, it looks like SC_ENABLE_MPIand SC_ENABLE_MPIIO are always identical, so I don't know if it really needed, but if you feel it is, we can.

In p4est it is possible to configure them differently, so we may create two separate variables. Thanks!

cburstedde commented 1 year ago

Btw the openmp is on its way out -- we do not expect to expose it far ino the future. Are the t8code folks needing it? @jmark

jmark commented 1 year ago

Btw the openmp is on its way out -- we do not expect to expose it far ino the future. Are the t8code folks needing it? @jmark

No, I don't think so. We are not using openmp in t8code.