search

cburstedde / libsc

The "sc" auxiliary library
www.p4est.org/
GNU Lesser General Public License v2.1
36 stars 34 forks source link

CMake: remove unused packaging script #143

Closed scivision closed 11 months ago

scivision commented 1 year ago

FindSC.cmake was never used by the CMake package, it was always superfluous, so remove it.

elykwilliams commented 1 year ago

Why bump the cmake min version number? Am I missing the change that requires 3.15?

scivision commented 1 year ago

Why bump the cmake min version number? Am I missing the change that requires 3.15?

It's to use CMake generator expression COMPILE_LANG_AND_ID

cburstedde commented 1 year ago

Thanks! Especially the cmakedefine for zlib will be a good thing. Would it be possible to make this PR not from the ECLAIRWaves organization, or to rebase it against @cburstedde's github repository? It has a develop branch that does not match the branch here.

cburstedde commented 11 months ago

Ok, using this repository now. Thanks!