find Zlib and test: ensure adler32_combine available

cburstedde / libsc

The "sc" auxiliary library

www.p4est.org/

GNU Lesser General Public License v2.1

36 stars 34 forks source link

find Zlib and test: ensure adler32_combine available #148

Closed scivision closed 10 months ago

scivision commented 10 months ago

It is desired to find Zlib as most personal computers (laptops, workstations) have a new-enough Zlib, and Linux distributions in general like Debian likewise have new-enough Zlib.

To avoid the issue with find_package(ZLIB) not checking for adler32_combine() and declaring imported target ZLIB::ZLIB, we instead search for the same Zlib binary file names as find_package(ZLIB) but run an adler32_combine quick check before declaring ZLIB::ZLIB.

cburstedde commented 10 months ago

Thanks again! I'm closing this one since it's coming from ECLAIRWaveS. Happy to go back to the previous PR workflow.