search

cburstedde / libsc

The "sc" auxiliary library
www.p4est.org/
GNU Lesser General Public License v2.1
36 stars 34 forks source link

CMake: add Jansson like Zlib #159

Closed scivision closed 9 months ago

scivision commented 9 months ago

Jansson would then be visible in p4est etc. without changes to those projects (once p4est updates its libsc Git submodule).

cburstedde commented 9 months ago

Thanks; much appreciated! There's a (transient?) CI fail though, wondering why that always seems to happen on MacOS.

Referring to @tim-griesbach for further comments.

tim-griesbach commented 9 months ago

Referring to @tim-griesbach for further comments.

Thanks to @scivision for the quick PR creation! I tried out the branch and it works for jansson analogously to zlib, i.e. if jansson is not found, it is deactivated but the user can activate an auto build of jansson. In the auto build case, I could successfully read a jansson file.

scivision commented 9 months ago

Thanks; much appreciated! There's a (transient?) CI fail though, wondering why that always seems to happen on MacOS.

this is fixed in https://github.com/cburstedde/libsc/pull/161