search

cburstedde / libsc

The "sc" auxiliary library
www.p4est.org/
GNU Lesser General Public License v2.1
36 stars 34 forks source link

Simplify MPI data types to old standard #175

Closed cburstedde closed 7 months ago

cburstedde commented 7 months ago

We had a couple data types that came in after MPI 1.3. Some were not consistently represented in all their aspects. We removed sc_MPI_SIGNED_CHAR and sc_MPI_DOUBLE_INT. We redefined INT8 to BYTE and UNSIGNED_LONG_LONG to LONG_LONG. Hopefully this works with very old MPI installations.

Update: to be very strict, we delete the MPI types for unsigned long long and int8_t. They are too new. Update: reinstate MPI_DOUBLE_INT, it is very old.

cburstedde commented 7 months ago

This might be the last change for version 2.8.6. Any comment @hannesbrandt @tim-griesbach ?

cburstedde commented 7 months ago

Thanks, about to merge and release if there are no further comments.

hannesbrandt commented 7 months ago

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

cburstedde commented 7 months ago

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

It's a weird thing, 12 bytes and all. But for the sake of backwards compatbility, letting it live and reducing the diff as much as possible would be a good thing. Would you be able to do this?

cburstedde commented 7 months ago

Thanks, about to merge and release if there are no further comments.

I saw that MPI_DOUBLE_INT is part of MPI standard 1.3. Do we want to remove sc_MPI_DOUBLE_INT nonetheless?

It's a weird thing, 12 bytes and all. But for the sake of backwards compatbility, letting it live and reducing the diff as much as possible would be a good thing. Would you be able to do this?

Don't worry, I'm on it.