search

cburstedde / libsc

The "sc" auxiliary library
www.p4est.org/
GNU Lesser General Public License v2.1
35 stars 34 forks source link

CI:CMake: add GCC-14 #184

Closed scivision closed 4 months ago

scivision commented 4 months ago

Note: other PR using CMake may want to rebase on this PR once it's merged. This also fixes new failures in previously working CI due to changes in the past week in GitHub Actions runner images.

cburstedde commented 4 months ago

Cool! Pinging @dutkalex wrt. the shared configure variable: is it handled by #178?

dutkalex commented 4 months ago

Cool! Pinging @dutkalex wrt. the shared configure variable: is it handled by #178?

Can you elaborate? I'm not sure I quite understand your question @cburstedde

cburstedde commented 4 months ago

Cool! Pinging @dutkalex wrt. the shared configure variable: is it handled by #178?

Can you elaborate? I'm not sure I quite understand your question @cburstedde

I was thinking -Dmpi is becoming a shortcut to define SC_ENABLE_MPI in that PR, same for debug. With -Dshared, we do no such thing iirc, so this question may be void?

dutkalex commented 4 months ago

I was thinking -Dmpi is becoming a shortcut to define SC_ENABLE_MPI in that PR, same for debug. With -Dshared, we do no such thing iirc, so this question may be void?

I believe I did not remove any -Dshared flag in #178 (IIRC)