cburstedde / libsc

The "sc" auxiliary library

www.p4est.org/

GNU Lesser General Public License v2.1

36 stars 34 forks source link

CMake: Fix pkgconf install path in symbolic link #189

Closed elykwilliams closed 5 months ago

elykwilliams commented 5 months ago

Fix pkgconf install path in symbolic link

Closes issue #187.

Proposed changes: The CMAKE_INSTALL_PATH was being set an configure time and not using the value present at install time. This change will allow all supported cmake versions to specify the install prefix when installing via cmake --install . --prefix=/path/to/install.

Note that this change will cause cmake to issue a fatal error and abort install if the symbolic link is not created, instead of failing passively as before.

cburstedde commented 5 months ago

Thanks! So far we had not given the pkgconfig support much coverage. If we were eventually to arrive at installed .pc files that actually work the way Linux distributions need it to, and are identical between autotools and CMake, that would be another major step forward.

cburstedde commented 5 months ago

We may augment our CI eventually to check into the generated .pc contents.