cbuschka / beanshell2

Automatically exported from code.google.com/p/beanshell2
0 stars 0 forks source link

Move the (long-time) failing unit tests into a separate Ant target #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The following tests are apparently well-known to fail.

test-scripts failures:

     [java] FAILED Tests:
     [java]     class13.bsh
     [java]     class3.bsh
     [java]     classinterf1.bsh
     [java]     commands.bsh
     [java]     run.bsh

I suggest we break out the "failing" tests into a separate ant target 
"known-failing-tests". That will expedite validation of the codebase when new 
patches applied.  

I am volunteering to make this new ant target, and in fact will assign the bug 
to myself.  Any comments welcome, otherwise will do this and check in changes 
within 48 hours.

Original issue reported on code.google.com by javadba@gmail.com on 29 May 2011 at 11:43

GoogleCodeExporter commented 9 years ago
How do I assign this to myself?  Or do I need to wait for a project owner to do 
this?

Original comment by javadba@gmail.com on 29 May 2011 at 11:44

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This issue was closed by revision r84.

Original comment by pejob...@gmail.com on 16 Sep 2011 at 3:33

GoogleCodeExporter commented 9 years ago
There are now two targets:
1) "junit-tests" skips failing tests for known issues
2) "junit-tests-all" executes all tests, including failing tests

This is achieved by setting the system property "skip_known_issues" in 
build.xml.
This flag is read by class "bsh.FilteredTestRunner". This runner must be 
specified by the junit annotation "@RunWith". Then at test method level specify 
the annotation "@Category" with value "bsh.KnownIssue.class". E.g. see test 
class "bsh.Issue_7_Test" for an example.

Original comment by pejob...@gmail.com on 17 Sep 2011 at 12:38

GoogleCodeExporter commented 9 years ago

Original comment by pejob...@gmail.com on 20 Oct 2011 at 7:12