search

cbusillo / BD_to_AVP

3D Blu-ray to Apple Vision Pro converter
GNU General Public License v3.0
63 stars 5 forks source link

Loading a config with unlinked HEVC / Upscale qualities sets both to Upscale quality #38

Closed Netruk44 closed 3 days ago

Netruk44 commented 6 days ago

If you save a config with the quality set to 75 HEVC quality and 50 Upscale quality, when you load that config later it'll load as 50 HEVC quality and 50 Upscale quality, with the values linked.

Netruk44 commented 6 days ago

(You may need to exit and load the config to get the issue to happen, since that's how I'm hitting the problem)

cbusillo commented 6 days ago

Fixed in master. I didn't see a reason to save the setting to config, I missed this. Thanks

cbusillo commented 4 days ago

v0.2.134 should contain this fix, please let me know if you notice any issues

Netruk44 commented 3 days ago

I just tried the latest version in master and this is still happening,

Netruk44 commented 3 days ago

Looks like I can't edit this issue to re-open it. I can either make a new issue or we could just stay here, I don't mind 😛

cbusillo commented 3 days ago

Sorry, I must have done a bad job testing. Initially all boolean values were default false. I was removing the option from the config file if they were falsey, due to issues with blank values. Now I am explicitly handling False. Master is updated and issue is reopened.

Netruk44 commented 3 days ago

Looks good now, thanks!