search

cbyrohl / scida

scida is an out-of-the-box analysis tool for large scientific datasets. It primarily supports the astrophysics community, focusing on cosmological and galaxy formation simulations using particles or unstructured meshes, as well as large observational datasets. This tool uses dask, allowing analysis to scale.
https://scida.io
MIT License
28 stars 4 forks source link

Error when loading GAIA dataset in tutorial #101

Closed EGaraldi closed 10 months ago

EGaraldi commented 11 months ago

When loading GAIA dataset I get the following errors INFO:scida.interfaces.mixins.units:Cannot parse unit string 'electron'.s-1' from metadata description. Skipping. INFO:scida.interfaces.mixins.units:Cannot parse unit string 'mag' from metadata description. Skipping. INFO:scida.interfaces.mixins.units:Cannot parse unit string 'electron'.s-1' from metadata description. Skipping. INFO:scida.interfaces.mixins.units:Cannot parse unit string 'mag' from metadata description. Skipping. INFO:scida.interfaces.mixins.units:Cannot parse unit string 'electron'.s**-1' from metadata description. Skipping. INFO:scida.interfaces.mixins.units:Cannot parse unit string 'mag' from metadata description. Skipping.

cbyrohl commented 11 months ago

This should just be info output (rather than an error; due to units that cannot be parsed by pint), in parts due to limited logarithmic unit support and unknown unit 'electron' (?), so we will have to think about how to handle this for now. I would keep the verbosity to make the user aware of limited units for these fields.

EGaraldi commented 10 months ago

I see. I think at the very least there should be a comment in the tutorial explaining this behavior is understood and expected for the dataset. Maybe the INFO can be made more explicit by saying something like "This unit will not be available" rather than just "Skipping"