cbysnoopy / python-on-a-chip

Automatically exported from code.google.com/p/python-on-a-chip
0 stars 0 forks source link

Add support for string concatenation #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
ipm> a="test"
ipm> b="thing"
ipm> a+b
Error:     0xED
  Release: 0x08
  FileId:  0x09
  LineNum: 407
Traceback (top first):
  <ipm>()
  ipm()
  main()
  <module>.

What is the expected output? What do you see instead?
"testthing"

Original issue reported on code.google.com by dwhall...@gmail.com on 31 Aug 2009 at 2:55

GoogleCodeExporter commented 9 years ago
Patch from Trammel Hudson attached.

Original comment by dwhall...@gmail.com on 31 Aug 2009 at 2:56

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 31 Aug 2009 at 2:58

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 3 Sep 2009 at 7:10

GoogleCodeExporter commented 9 years ago
Not using the attached patch because it uses snprintf() and there is a 
reasonable way 
to do it using sli_memcpy().  Created new function string_concat() in strobj.c. 
 Added 
case to BINARY_ADD and INPLACE_ADD to handle string concatenation in interp.c.

Added system test t242.

Original comment by dwhall...@gmail.com on 3 Sep 2009 at 8:11

GoogleCodeExporter commented 9 years ago
This new feature is not made conditional because it is the *only* way to 
concatenate 
strings so far and that is deemed a critical feature to have.

System tests pass, mainlined directly.  See r371.

Original comment by dwhall...@gmail.com on 3 Sep 2009 at 8:22

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 7 Sep 2009 at 1:47

GoogleCodeExporter commented 9 years ago
Changing Milestone-r10 to Milestone-r09

Original comment by dwhall...@gmail.com on 7 Mar 2010 at 6:26

GoogleCodeExporter commented 9 years ago
Changed r09 to R09

Original comment by dwhall...@gmail.com on 12 Mar 2010 at 8:22

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 13 Mar 2010 at 1:30