search

cc-ai / climategan

Code and pre-trained model for the algorithm generating visualisations of 3 climate change related events: floods, wildfires and smog.
https://thisclimatedoesnotexist.com
GNU General Public License v3.0
75 stars 18 forks source link

[WIP] ADVENT conflict-solving branch #83

Closed tianyu-z closed 4 years ago

tianyu-z commented 4 years ago

I will request a review when I am ready (finishing the confliction and resolving the conversation)

vict0rsch commented 4 years ago

I know this is WIP but be careful: you have a weird .bak file which should not be committed and not pushed + you are overwriting the current defaults.yaml with an outdated one

vict0rsch commented 4 years ago

Also can you give this PR a more explicit name? I'm glad you're solving issues but that's not an ideal name haha

tianyu-z commented 4 years ago

I know this is WIP but be careful: you have a weird .bak file which should not be committed and not pushed + you are overwriting the current defaults.yaml with an outdated one

Understood. That's why I decided to leave these 2 most important files until I get up (with a clear mind) haha.

tianyu-z commented 4 years ago

Also can you give this PR a more explicit name? I'm glad you're solving issues but that's not an ideal name haha

Got it!

tianyu-z commented 4 years ago

I didn't integrate the ADVENTAdversarialLoss into the get_losses function because it's a little bit different. If you want me to put it into get_losses, just notify me.

tianyu-z commented 4 years ago

Advent dicription: https://drive.google.com/file/d/13gbw5NNPANoWeFyIg7Pf8G4v_b8-53Az/view?usp=sharing

Google Docs
ADVENTLoss