search

cc-archive / cc-link-checker

Automated link checker for legalcode and license URLs
MIT License
9 stars 13 forks source link

[CC7] Deed Link Checker #92

Closed Audiosutras closed 4 years ago

Audiosutras commented 4 years ago

Fixes

Fixes #75 by @TimidRobot

Description

This PR adds link checking for deeds.

  1. Checks deed links on creativecommons.org 
    pipenv run link_checker --deeds
  2. Refactors link_checker.py and adds constants.py and utils.py
    • To run link checking for both legalcode license and deeds: pipenv run link_checker
    • To runs link checking for only the legalcode licenses: pipenv run link_checker --licenses
  3. Refactors test_link_checker.py and adds test_utils.py

Tests

pipenv run pytest -v

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [ ] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [x] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [ ] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
Audiosutras commented 4 years ago

It looks like the --local options does not work with --deeds

It looks like the --local options does not work with --deeds

@TimidRobot I'm not too sure how to get deeds locally. Do you have any suggestions? The last time we talked you pointed me to the django template for standard_deeds; but locally we should be checking static pages. I appreciate the help and your time.

TimidRobot commented 4 years ago

It looks like the --local options does not work with --deeds

@TimidRobot I'm not too sure how to get deeds locally. Do you have any suggestions? The last time we talked you pointed me to the django template for standard_deeds; but locally we should be checking static pages. I appreciate the help and your time.

The --local option should only apply to legalcode (which should be the starting place for what deeds should be present)

Audiosutras commented 4 years ago

It looks like the --local options does not work with --deeds

@TimidRobot I'm not too sure how to get deeds locally. Do you have any suggestions? The last time we talked you pointed me to the django template for standard_deeds; but locally we should be checking static pages. I appreciate the help and your time.

The --local option should only apply to legalcode (which should be the starting place for what deeds should be present)

I'll remove the --local option from deeds. Currently in this pr legalcode is the starting place for getting deeds; but I should rename a couple of variables (deed_names) to make that clearer in the PR.

TimidRobot commented 4 years ago

I'll remove the --local option from deeds. Currently in this pr legalcode is the starting place for getting deeds; but I should rename a couple of variables (deed_names) to make that clearer in the PR.

I added it back in and updated both legalcode and deeds execution paths to use the same function