search

cc-archive / cccatalog

[PROJECT TRANSFERRED] Mapping the commons towards an open ledger and cc search.
https://github.com/WordPress/openverse-catalog
MIT License
63 stars 60 forks source link

Science museum workflow #411

Closed kss682 closed 4 years ago

kss682 commented 4 years ago

Fixes

Fixes #408 by @mathemancer

Description

Airflow DAG script to run the science museum script

Technical details

Faced few errors while testing not sure of its origin . First occurrence of it was when the test passed and removed some comments and then testing again failed . 

/tmp/pytest-of-airflow/pytest-0/test_dag_loads_with_no_errors7
[2020-05-29 07:45:54,791] {dagbag.py:403} INFO - Filling up the DagBag from /tmp/pytest-of-airflow/pytest-0/test_dag_loads_with_no_errors7
[2020-05-29 07:45:54,792] {dagbag.py:229} INFO - File /usr/local/airflow/dags/science_museum_workflow.py assumed to contain no DAGs. Skipping.
{}

Mentioning this problem since not sure why this occurred suddenly. Now the test is passing.

Tests

Screenshots

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `master` branch of the repository. - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [x] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
mathemancer commented 4 years ago

I think (hope) that the issue was due to the file sync sometimes taking a moment to catch up between your local filesystem (where you were editing) and that of the docker container. Sometimes that can cause issues.

Regardless, I can't replicate it, and the tests are passing at the moment. We'll just keep an eye on it.