Favourites list shouldn't be editable

cc-archive / open-ledger

Prototype code and examples for work on the Creative Commons "CC Search" project

MIT License

48 stars 23 forks source link

Favourites list shouldn't be editable #101

Closed eoinnoble closed 7 years ago

eoinnoble commented 7 years ago

The 'Favourites' list probably shouldn’t be editable, since you can’t really edit it – if you change its name to something else and favourite another photo a new 'Favourites' list will appear on the lists screen.

lizadaly commented 7 years ago

I wasn't sure how to implement this: as a fake list that just shows what you have Favorited and is otherwise immutable, or (what I did) a real list that listens to 'add favorite' events but is otherwise independent. Obviously you expected the former behavior so I'll swap the implementation (it's easier anyway).

lizadaly commented 7 years ago

Folding this into #97