cc-archive / open-ledger

Prototype code and examples for work on the Creative Commons "CC Search" project
MIT License
48 stars 23 forks source link

IE11 #160

Closed rheaplex closed 7 years ago

rheaplex commented 7 years ago

A user has reported that search is not working on IE11.

I tested in IE11 on Windows 8 and did have problems -

image

The console shows the following for this search:

image

IE13 and 14 on Windows 10 didn't have this problem.

IE11 on All platforms tested (Windows 7, 8, 8.1) did have this problem.

IE 10 on Windows 7 had the problem. The error log is:

image

IE 9 on Windows 7 had the problem until I cleared the cache, when it then looked like this:

image

(so, single column.)

The error log for the problem is:

image

IE8 doesn't render well and doesn't show results:

image

The log for this is:

image

lizadaly commented 7 years ago

We should only support IE 11 and up; MS itself does not support 10 or below.

It looks like the bug is in grid.js (which may be the underlying masonry plugin that does the image layout). If a fix isn't trivial, we could simply bypass the masonry layout and fall back to a rigid grid for IE.

rheaplex commented 7 years ago

Not supporting unsupported browsers makes sense. :-)

mmoreshead commented 7 years ago

Another report from a user:

Trying CC for the first time. I search for 'Caravaggio' at Metropolitan Museum of Art and get response '8 images' and now see 'Next' and 'Prev' on the screen, but no images. There is some momentary activity when I hit Next/Prev but no image appears.

Using Windows 10.

rheaplex commented 7 years ago

@mmoreshead Do we know which version of IE they are using? I assume 11 or earlier but any details are helpful. :-)

mmoreshead commented 7 years ago

this one is 10, it's in my note up there, easy to miss though.

rheaplex commented 7 years ago

It says Windows 10? If it's IE 10 on Windows that makes sense. :-)

lizadaly commented 7 years ago

IE 11 and Edge should now work.