Facetted search appears to pull blank screen on mobile

cc-archive / open-ledger

Prototype code and examples for work on the Creative Commons "CC Search" project

MIT License

48 stars 23 forks source link

Facetted search appears to pull blank screen on mobile #192

Closed little-wow closed 7 years ago

little-wow commented 7 years ago

Regular search works fine, but facets appear to make the page blank. Using IPhone 5 + Safari. Also checked on Chrome and Safari on desktop and appears to be functioning.

pa-w commented 7 years ago

[x] Try to reproduce (this seems to be a mobile only issue). ~~Maybe CSS?~~ Was able reproduce on Chrome in responsive mode... I suspect it has to do with imagesloaded behavior on mobile or we might be misidentifying mobile browsers as IE? Relevant code here.
[ ] Test locally and in staging
[ ] Deploy!

pa-w commented 7 years ago

So, apparently imagesloaded is the responsible and maybe it doesn't help that we use it once the DOM has loaded BUT I am going to try to wait until window.load has triggered to perform the checks.

Here is, I think, imagesloaded bug that is causing this. Note that there is a question regarding minifying code (which we do) https://github.com/desandro/imagesloaded/issues/156

pa-w commented 7 years ago

So, it worked! changing the event to window.load instead of DOMDocumentLoad fixed most of the issues.

Fixed in a78d747de78ec6ea1469aedd985015dec32f9c55