cc-archive / vocabulary-legacy

A cohesive design system & Vue component library to unify the web-facing Creative Commons
https://cc-vocabulary.netlify.app
MIT License
88 stars 129 forks source link

Disable Netlify builds on pull requests #1002

Closed brylie closed 2 years ago

brylie commented 3 years ago

Netlify is currently running several jobs on each pull request submitted to this project. The Netlify jobs create a lot of noise and some confusion in our CI/review process.

Task

Akpjunior94 commented 3 years ago

@brylie I will take up this issue. Thanks

brylie commented 3 years ago

@Akpjunior94, thanks! I've assigned you to the issue.

Akpjunior94 commented 3 years ago

Thanks @brylie

Akpjunior94 commented 3 years ago

@brylie Based on my research I realized that the netlify workflow is an App integration which means it can be disabled on the repo settings with the right permission.

I raised a Dummy PR and I noticed that the netlify deploy is canceled image

dhruvkb commented 3 years ago

This issue should've been staff-only. I had the Netlify GUI access so I've disabled preview deployments for PRs from the Netlify dashboard.

brylie commented 3 years ago

@dhruvkb, would you please grant me (brylie@creativecommons.org) access to the Netlify dashboard for CC organization repositories?

dhruvkb commented 3 years ago

@TimidRobot and @annatuma have the "Owner" permissions to modify team members. I'm a "Collaborator" to I'm only allowed to remove myself.

Akpjunior94 commented 3 years ago

This issue should've been staff-only. I had the Netlify GUI access so I've disabled preview deployments for PRs from the Netlify dashboard.

Okay @dhruvkb thanks for the update