cc-archive / vocabulary-legacy

A cohesive design system & Vue component library to unify the web-facing Creative Commons
https://cc-vocabulary.netlify.app
MIT License
88 stars 129 forks source link

Error with build scripts #1006

Closed MuluhGodson closed 3 years ago

MuluhGodson commented 3 years ago

Description

This PR https://github.com/creativecommons/vocabulary/pull/996 reorganized the scripts files but the changes weren't updated in the package.json file.

The new package.json scripts should be:

 "scripts": {
    "serve": "start-storybook -p 6006 --ci -s ./src/assets",
    "test:unit": "vue-cli-service test:unit",
    "lint": "vue-cli-service lint",
    "build:fonts": "bash ./scripts/build/fonts.sh",
    "build:storybook": "build-storybook -o ./docs -s ./src/assets",
    "build:vocabulary": "bash ./scripts/build/vocabulary.sh",
    "build:vue-vocabulary": "bash ./scripts/build/vue_vocabulary.sh",
    "test:vue-vocabulary": "vue-cli-service test:unit"
  },

Reproduction

  1. Run any build command, e.g npm run build:fonts
  2. See error.

Expectation

scripts should build correctly

Screenshots

image

Additional context

Resolution

MuluhGodson commented 3 years ago

@brylie Hello I have already updated the changes and will be happy to open a PR if assigned.

brylie commented 3 years ago

Thanks. I've assigned you :smile: