search

cc-archive / vue-vocabulary

A Vue component library implementing a cohesive design system to unite the web facing Creative Commons
https://cc-vue-vocabulary.netlify.app/
MIT License
25 stars 53 forks source link

Set up CD using GitHub Actions #214

Closed SaurabhAgarwala closed 4 years ago

SaurabhAgarwala commented 4 years ago

Fixes

Fixes #5 by @dhruvkb

Description

This PR adds a new workflow for Continuous Deployment using Github Actions which will push the updated packages to npm when a new release is published.

Technical details

Please note that the NPM Authentication Token has to be stored as a GitHub secret by the name NPM_TOKEN for this workflow to complete successfully

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the `master` branch of the repository. - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [ ] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
dhruvkb commented 4 years ago

I appreciate you doing both PRs simultaneously. I'll review the other one creativecommons/vocabulary#321 and you will need to make the corresponding changes here as well.

SaurabhAgarwala commented 4 years ago

@dhruvkb I have made the instructed changes in both the PRs. Please review them again.

SaurabhAgarwala commented 4 years ago

@dhruvkb The instructed changes have been made. Please review it again

SaurabhAgarwala commented 4 years ago

@dhruvkb The final changes have been made in both the PRs

SaurabhAgarwala commented 4 years ago

I have updated the working directory to the project root. Please review it.