SquidDev
commented
5 years ago With the You didn't mount this location error, can you try with multiple peripherals attached to one computer? Normally this only occurs if you try to unmount something which somebody mounted, or the original mounting failed - also check your .mount calls don't return null!
WRT the Too many open files error, ideally you should be caching the mounts on your end, as they're not super-cheap to construct (we scan that folder/file of the zip directory to find all files). However, CC:T is also definitely failing to clean up some resources, so I'll look into that.
LemADEC
Useful information to include:
When attaching computer controlled blocks to a computer, my mod is also mounting different preloaded scripts as resources. When detaching the computer, my mod asks to dismount them. For some obscure reason, on our server, it fails to unmount them with this callstack:
I'm not able to reproduce in single player with just CC-tweaked and Computronics. So, I'm probably missing something. Any idea on what could be triggering this?
Furthermore, after some time, the mount fails due to 'Too many open files', which means there's a leak. I suspect the unmounting didn't happen properly, and also, CC doesn't cache the RessourceMount, hence constantly creating new ones?
Here's my existing code for mounting a file or folder:
I can add a cache there, but that seems weird when CC on 1.7.10 never had such a resource leak on a busy server, so it feels like a regression somewhere.