search

cc-tweaked / CC-Tweaked

Just another ComputerCraft fork
https://tweaked.cc
940 stars 211 forks source link

Add iris to Shader Mod check #1969

Closed maxnoller closed 2 months ago

maxnoller commented 2 months ago

Added iris to shader mod check

Fixes #1967

Hex4dec commented 2 months ago

Are you sure this is the correct fix? Note that you are adding the check to the Forge project, and Oculus is the Forge version of Iris. This shouldn't do anything.

Nevermind, seems like Iris natively supports NeoForge.

maxnoller commented 2 months ago

I tested this in the ATM10 Modpack Alpha that uses Neoforge and Iris (I encountered the bug there) and this one line change fixed the problems and so far I have been playing for 4 hours with it and have not noticed any problems. I haven't touched MC modding in a long time so im not sure this is all that is needed. Also regarding the failed test, I dont think my code change caused this right? Should I still look into fixing that?

Hex4dec commented 2 months ago

No, pretty sure CC:T tests are a mess.

Erb3 commented 2 months ago

(-14930832, -60, -4764970) Moved 32 items into a double chest Expected: [<32>] but: was null at -14930830,-58,-4764968 (relative: 2,2,2) (t=6)

Looks like a flaky test - not your fault.

SquidDev commented 2 months ago

Thank you for the PR! I'm afraid I ended up fixing this in a slightly different way (63181e73a14f840a360125e1e6b2be8907d551f3) — we no longer need the Oculus check at all, as Oculus doesn't support MC 1.21.

maxnoller commented 2 months ago

okey that looks like a slightly more comprehensive way to deal with this issue than what I did. Thanks for dealing with this os fast, now I can finally create Bar-Chart galore in Minecraft again