search

cc-tweaked / CC-Tweaked

Just another ComputerCraft fork
https://tweaked.cc
934 stars 211 forks source link

Duplicate recipe #532

Closed lachiu closed 4 years ago

lachiu commented 4 years ago

Useful information to include:

Craftable one: (check the EMC value (by removing projecte folder of said modpack you get the defaults)

Uncraftable one, yet 32 emc more

The mining turtle for instance uses the uncraftable one.

CraftTweaker says it's either CC-Tweaked or the modpack.

Uncraftable one - Craftable one, in that order.

Upon placing and mining the craftable one I get the uncraftable one. ComputerCraft 1.80 didn't have this.

SquidDev commented 4 years ago

This is a problem with the modpack's CraftTweaker scripts. They unregister a recipe for computercraft:turtle_extended, but the incorrectly register one for computercraft:turtle. This is no longer used within the mod's code and exists only for world-compatibility reasons.

recipes.remove(<computercraft:turtle_expanded>);
recipes.addShaped(<computercraft:turtle>,
  [[<ore:ingotIron>, <ore:ingotIron>, <ore:ingotIron>], 
   [<ore:ingotIron>, <computercraft:computer>, <ore:ingotIron>], 
   [<minecraft:iron_ingot>, <ore:chest>, <ore:ingotIron>]]);

There's also some weird stuff they're doing with crafty turtles, but I'm afraid I don't understand that at all.

lachiu commented 4 years ago

recipes.remove(); recipes.remove(); recipes.addShapeless(.withTag({leftUpgrade: 2 as short}), [, ]); recipes.addShapeless(.withTag({leftUpgrade: 2 as short}), [, ]);

recipes.addShaped(, [[, , ], [, , ], [, , ]]);

recipes.addShaped(, [[, , ], [, , ], [, , ]]);

These were there already.

Pulz-TCP commented 4 years ago

You were told to remove the portions of the script that add/register new recipes- hence the duplicated JEI entry, as it is no longer used within the mods code.

SquidDev commented 4 years ago

Well, really that computercraft:turtle needs to be replaced with computercraft:turtle_extended. But this is something you should probably report to the pack authors instead of trying to change yourself.

Pulz-TCP commented 4 years ago

@lachiu

You are running a modified version of my modpack. Without your modifications, my modpack runs and operates completely fine. @SquidDev has (thank you) pointed out that obviously my old 'turtle fixes' are actually problematic and no longer required anyway. But contrary to what he said, please do not contact me asking me to fix issues you have introduced yourself! I do not currently have the free time to investigate customization made by individuals.

The bad recipe only introduces one issue: some turtle types appear as CRAFTY TURTLE in their JEI entry (crafty turtles just have the name 'turtle' in JEI). I have just tested the modpack and see why nobody has reported turtle issues to me: all turtle types remain fully craftable despite appearing as CRAFTY TURTLE's in JEI. CRAFTY TURTLE's have an extra 32 emc compared to the regular ones, as they are made with a crafting table (4 planks, 8 emc each 4*8=32). So that is where your magic 32 emc is coming from. But again, this is purely visual in JEI and the modpack does not have EMC values for turtles by default anyway.

I haven't got time to load up CC:Tweaked today, but I am fairly sure that the extent of your issue is purely visual and in JEI only. With that said, I have already removed the recipe- you can make the same modifications manually as https://github.com/Pulz-TCP/TheClassicPack/commit/dcb5dfd9692bf3959fa7c0c1006cd5f72ab6d03f