search

cc-tweaked / CC-Tweaked

Just another ComputerCraft fork
https://tweaked.cc
934 stars 211 forks source link

FishyTurtle #545

Closed crabdancing closed 4 years ago

crabdancing commented 4 years ago

Fishing is a very boring repetitive task. There are many mods that automate this, but they do so in uninteresting ways that don't tend to have much challenge. It should be possible to equip a turtle with a fishing rod and make a FishyTurtle, and automate it via programming! :D

SquidDev commented 4 years ago

I'm tagging this as "won't fix" for now, as I'm inclined to say it'd be better suited to an external mod, such as Plethora (hah, as if it'll ever be updated). As always, would like to hear other people's thoughts though.

From what I remember, fishing rods are nasty (see SquidDev-CC/plethora#116) and make lots of assumptions that don't hold up for turtles. There's a reason most mods just magic fish out of nowhere :p.

crabdancing commented 4 years ago

@SquidDev aww that's a real shame. Seems like it'd be possible to do with Fabric mixins... I'd offer to contribute code, but the Fabric version is downstream. :S

crabdancing commented 4 years ago

I could contribute the mixin code to the downstream Fabric-based project, and then maybe you could consider up-porting it using MixinBootstrap?

SquidDev commented 4 years ago

I think the upstream one is actually this project :p. I'd definitely recommend opening an issue there too - they've got a couple of other features which aren't in CC, so might be receptive to this too.

Forge has native support for Mixin now, so one shouldn't need to depend on MixinBootstrap. That said, I'm pretty reluctant to make CC:T a core mod. I've done enough core mod hackery in the past, and while it's safer nowadays, it's still something I'd rather not do.

crabdancing commented 4 years ago

@SquidDev whoops! Sorry about that. Really shouldn't github when I just woke up.

crabdancing commented 4 years ago

In Forge-land, everything that manipulates game code is considered core mods? In Fabric mixins are just kinda standard. You just do them in ways that maximize compatibility.

crabdancing commented 4 years ago

You'll have to forgive my lack of familiarity. I never modded with Forge.

SquidDev commented 4 years ago

Yeah, literally anything which "modifies the core of the game". Forge's preference is that any (major) hooks belong in Forge, as that way they can ensure things work with each other and make it much easier to debug things.

Obviously the issue with that model is that it's much harder to get these changes in, but when they're there for everyone.

crabdancing commented 4 years ago

With Fabric mixins, it's pretty powerful and it's usually possible to do it in a sneaky way that shouldn't mess up anyone else's code. I could try to implement this with the Fabric version after talking to some veteran Fabric modders ... maybe a separate optional coremod library for making fishing by fake players easier in general could be created, for the Forge solution?

Devan-Kerman commented 4 years ago

it's Sponge's mixin not Fabric's*

crabdancing commented 4 years ago

@Devan-Kerman They didn't make any changes from upstream code? :P

Devan-Kerman commented 4 years ago

some minor tweaks to make it work for fabric, it used to have some changes but they're gone now

crabdancing commented 4 years ago

Ah. So it's basically just copied and pasted straight from Sponge. Very interesting!